Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: check ability to detect abstractions and patterns in code INTELLIJ-29 #14

Merged
merged 34 commits into from
Jul 10, 2024

Conversation

kmruiz
Copy link
Contributor

@kmruiz kmruiz commented Jul 3, 2024

Description

Checklist

Open Questions

@github-actions github-actions bot added the no release notes It's a chore and doesn't require release notes. label Jul 3, 2024
Copy link

github-actions bot commented Jul 4, 2024

Coverage Report

Overall Project 86.49% -13.37%
Files changed 85.98%

File Coverage
JavaDriverDialect.kt 100%
JavaDriverDialectParser.kt 89% -11%
NamespaceExtractor.kt 87.69% -12.31%
PsiMdbTreeUtil.kt 83.2% -16.31%

@kmruiz kmruiz marked this pull request as ready for review July 9, 2024 09:30
@kmruiz kmruiz requested a review from mcasimir July 9, 2024 09:31
@kmruiz kmruiz requested review from addaleax and himanshusinghs July 9, 2024 09:31
@kmruiz kmruiz self-assigned this Jul 9, 2024
@kmruiz kmruiz requested a review from addaleax July 9, 2024 13:58
@kmruiz kmruiz changed the title chore: check ability to detect abstractions and patterns in code feat: check ability to detect abstractions and patterns in code Jul 9, 2024
@kmruiz kmruiz changed the title feat: check ability to detect abstractions and patterns in code feat: check ability to detect abstractions and patterns in code INTELLIJ-29 Jul 9, 2024
@github-actions github-actions bot added the feature Adds a new feature. label Jul 9, 2024
@kmruiz kmruiz removed the no release notes It's a chore and doesn't require release notes. label Jul 9, 2024
@kmruiz
Copy link
Contributor Author

kmruiz commented Jul 9, 2024

@addaleax

Covering your comments about having the driver file in the repo, I did the following:

I added the dependency in the project as a test dependency, so it's downloaded:

https://github.com/mongodb-js/intellij/pull/14/files#diff-69a251e7d539a013829995c55bfd772997fc9c8be6d793647f1736612ad9b252R44

And then I did some magic to get the path to the JAR file within the class that has been loaded:

https://github.com/mongodb-js/intellij/pull/14/files#diff-4105cf6c7c9d9e5b62b3713026a02b362b5ca5765ced48bced07f006ad038876R191-R206

@kmruiz kmruiz merged commit 3c1d048 into main Jul 10, 2024
11 checks passed
@kmruiz kmruiz deleted the chore/intellij-29 branch July 10, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Adds a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants